Parent Directory
| 
Revision Log
| Links to HEAD: | (view) (download) (as text) (annotate) |
| Sticky Revision: |
FreeTDS: Make clearly safe narrowing conversions explicit. JIRA: CXX-3707.
FreeTDS: Address more LLVM Clang static analyzer (scan-build) feedback.
- query.c (tds_put_param_as_string): Bail immediately if
tds_convert_string fails.
- ct_bind: Drop redundant early colinfo assignment.
- dbprrow: Bail if somehow first encountering a non-REG_ROW, in which
case col_printlens will still be null.
- lang_ct_param.c (insert_test): Zero-initialize rows_found.
- rpc_ct_setparam.c (ex_display_results): Avoid memory leaks in some
error cases.
- dblib t001{3,4}.c (test): Avoid leaks when unable to open output file.
JIRA: CXX-5700.
Fix FreeTDS 1.0 compilation errors in single-threaded builds. JIRA: CXX-9729.
Address Clang static analyzer errors, many long-standing. There were corner cases in which NULL pointer dereferences, memory leaks, use of freed memory, or 0-sized allocations (technically yielding undefined behavior) could occur, at least in theory. TRUNK-0.95: 487516, 536372. JIRA: CXX-9729.
Address FreeTDS 1.0 compiler warnings.
* Harmonize type usage, via explicit casts where necessary (and safe).
In particular, ensure that upstream tests' tds_thread_proc routines
know to return DWORD rather than void* on Windows.
* Ensure that any headers checking (TDS_)HAVE_* #include <config.h> first.
* Keep static assertions warning-free by using _Static_assert where
available.
* Ensure that members of types that should be unhidden have unhidden
forward declarations; likewise for their members, recursively.
* Remove (comment out) unused variables and constants.
* Express -2**31 and -2**63 in a manner all compilers accept happily.
* For LLVM Clang, substitute __attribute__((visibility("default")))
for __attribute__((externally_visible)), which it doesn't support.
* Add no-op default: cases to switch statements that don't explicitly
cover all of TDS_SERVER_TYPE.
* ctlib.h: #define _CS_CURS_TYPE_* to TDS_CURSOR_STATE_* rather than
(typelessly) duplicating their values.
* thread.h: Correct tds_thread_proc and TDS_THREAD_PROC_DECLARE; Windows
threads are expected to return DWORD, not void*.
* dblib/bcp.c (_bcp_get_col_data): Remove a redundant test for
non-negativity.
* dblib/dblib.c: Express -2?\194?\179?\194?\185 in a manner all compilers accept happily.
* odbc/unittests/attributes.c: Tell the compiler fatal() will never return.
* odbc/unittests/common.h: When the ODBC 3 API is available, favor
SQLSetStmtAttr over SQLSetStmtOption, which is deprecated.
* tds/convert.c: Rename the string_to_result function to ensure IDEs
don't conflate it with the identically named wrapper macro.
* tds/gssapi.c: Suppress GSSAPI deprecation warnings on Mac OS X.
* tds/md[45].c: Use TDS_PUT_(U)A4 to populate word32 targets cleanly.
* tds/query.c: #include <sys/socket.h> if available, for send().
* tds/sspi.c: Define _WIN32_WINNT before <config.h>, which might
otherwise supply a slightly different definition.
TRUNK-0.95: 487511, 554113. JIRA: CXX-9729.
cs_convert, dbconvert: Truncate data as needed; update unit tests. * Automatically truncate strings that would overflow their destinations, mainly for the sake of bulk insertions. Notify the client at low severity (as a warning, essentially). Update upstream unit tests (ctlib t0006, dblib t0019) accordingly. * Fully honor *BINARY and IMAGE data buffer size limits in cs_convert. TRUNK-0.95: 487504. JIRA: CXX-9729.
Don't let FreeTDS log directly to stdout or stderr. * Substitute tdsdump_log, _csclient_msg, or dbperror as appropriate, introducing some new error codes for the latter two functions. * From cs_convert, call _csclient_msg in addition to tdsdump_log. TRUNK-0.95: 487502. JIRA: CXX-9729.
dblib.c: Honor dbsetversion in tdsdbopen; improve dbcolinfo and dbwritetext. * Added static function dbcoltablename. * Improved function dbcolinfo in order to call dbcoltablename and set an appropriate field up. * Fixed populating of TDS version in tdsdbopen. (Now done when there were explicit calls to dbsetversion.) * Check dbconvert's return value in dbwritetext. TRUNK-0.95: 487486. JIRA: CXX-9729.
Add upstream FreeTDS files from Branch-1_00, as of 2017-12-28. Incorporate fixes that didn't make it into the release (many of which would otherwise have wound up coming in as patches). Upstream revision ID: R1_00-80-gd40d5e91 (last commit 2017-11-29). JIRA: CXX-9729.
This form allows you to request diffs between any two revisions of this file. For each of the two "sides" of the diff, enter a numeric revision.
| NCBI Systems Team">NCBI Systems Team | ViewVC Help |
| Powered by ViewVC 1.1.20 |